Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more robustly handle npm version changes #145

Merged
merged 2 commits into from
Jul 18, 2024
Merged

more robustly handle npm version changes #145

merged 2 commits into from
Jul 18, 2024

Conversation

bmeck
Copy link
Collaborator

@bmeck bmeck commented Jul 18, 2024

this fixes modern NPM integration

@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, network, shell, unsafe 0 10.1 MB gar
npm/[email protected] environment, eval, filesystem, network, shell, unsafe 0 9.24 MB gar

View full report↗︎

jdalton
jdalton approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less what my hunch was to fix it. We can add more checks as npm changes things without exact version sniffs.

@bmeck bmeck merged commit 519ab8a into master Jul 18, 2024
11 checks passed
@bmeck bmeck deleted the better-npm-errors-and-detection branch July 18, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmeck @jdalton